-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top banner #60
Top banner #60
Conversation
mimanshi-plivo
commented
Aug 4, 2023
- Added top banner to style guides
src/components/TopBanner/index.js
Outdated
> | ||
{loading && ( | ||
<Block> | ||
<Icon.Loading size={16} color="white" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon.Loading has strokeWidth
and trackColor
props. You can use it if you want. Not sure if color="white" is what we want.
gap: 16px; | ||
// margin-left: 4px; | ||
|
||
.sg.cnto-btn.contacto-button--small { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this style to Button.scss file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be add a new button type
<Button type="link" variant="underline" color="white" />
&--underline { | ||
text-decoration: underline; | ||
height: 24px; | ||
padding: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any hover style required?